Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: TextareaコンポーネントのmaxLength属性をmaxLetters属性に変更 #4607

Merged
merged 4 commits into from
May 9, 2024
Merged

fix!: TextareaコンポーネントのmaxLength属性をmaxLetters属性に変更 #4607

merged 4 commits into from
May 9, 2024

Conversation

AtsushiM
Copy link
Member

@AtsushiM AtsushiM commented Apr 25, 2024 •
edited by uknmr
Loading

Related URL

https://smarthr.atlassian.net/browse/SHRUI-955

Overview

What I did

  • TextareaにmaxLengthを設定しても、実際に出力されるhtmlにはmaxLength属性は設定されない
  • maxLengthは実質あと何文字入力できるか表示するためだけの属性になっている
  • そもそもsmarthrとしてmaxLength属性は非推奨にしているため、 maxLength を maxLetters に変更して利用者のメンタルモデルと合わせたい

Capture

@yagimushi yagimushi force-pushed the fix-textarea-maxlength-to-limitlength branch from dd1b7da to 36f1cb2 Compare April 25, 2024 23:08
@AtsushiM AtsushiM marked this pull request as ready for review April 25, 2024 23:52
@AtsushiM AtsushiM requested a review from a team as a code owner April 25, 2024 23:52
@AtsushiM AtsushiM requested review from Qs-F and Tokky0425 and removed request for a team April 25, 2024 23:52
s-sasaki-0529
s-sasaki-0529 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Storybook 上で動作が変わっていないことが確認できました！

@yagimushi yagimushi force-pushed the fix-textarea-maxlength-to-limitlength branch from ac68651 to b8bf805 Compare April 26, 2024 03:32
@AtsushiM AtsushiM changed the title fix: TextareaコンポーネントのmaxLength属性をlimitLength属性に変更 fix: TextareaコンポーネントのmaxLength属性をmaxLetters属性に変更 Apr 26, 2024
@yagimushi yagimushi force-pushed the fix-textarea-maxlength-to-limitlength branch from b8bf805 to ee5a6b9 Compare April 26, 2024 03:34
@AtsushiM AtsushiM changed the title fix: TextareaコンポーネントのmaxLength属性をmaxLetters属性に変更 fix!: TextareaコンポーネントのmaxLength属性をmaxLetters属性に変更 Apr 26, 2024
oti
oti approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@oti oti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yagimushi yagimushi force-pushed the fix-textarea-maxlength-to-limitlength branch from f9f5dd2 to a876931 Compare May 6, 2024 23:48
oti
oti requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@oti oti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点コメントしました！

packages/smarthr-ui/src/components/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
@AtsushiM AtsushiM requested a review from oti May 7, 2024 00:17
oti
oti approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@oti oti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!(2)

Qs-F
Qs-F approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Qs-F Qs-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxLength → maxLettersに関してはLGTMです！

uknmr
uknmr requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「あと n/n 文字」という表記は意匠も含めて調整した方がよさそうなので、マージされないように request change 入れておきます。

@AtsushiM AtsushiM merged commit c0f91cc into master May 9, 2024
8 checks passed
@AtsushiM AtsushiM deleted the fix-textarea-maxlength-to-limitlength branch May 9, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@s-sasaki-0529 s-sasaki-0529 s-sasaki-0529 approved these changes

@Qs-F Qs-F Qs-F approved these changes

@oti oti oti approved these changes

@Tokky0425 Tokky0425 Awaiting requested review from Tokky0425 Tokky0425 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AtsushiM @oti @Qs-F @s-sasaki-0529 @uknmr