chore: ESLint v9 #5197
Merged
chore: ESLint v9 #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
commented
Dec 16, 2024
| 'packages/smarthr-ui/lib/', | ||
| 'packages/smarthr-ui/.storybook', | ||
| ] | ||
| }, |
There was a problem hiding this comment.
FlatConfig では、 ignores のみを持つオブジェクトを定義することで、全体の ignore リストが設定できるらしいです。
s-sasaki-0529
commented
Dec 16, 2024
| @@ -60,7 +60,7 @@ export function ButtonWrapper({ | |||
| if (props.isAnchor) { | |||
| const { anchorRef, elementAs, isAnchor: _, ...others } = props | |||
| const Component = elementAs || 'a' | |||
| // eslint-disable-next-line jsx-a11y/anchor-has-content | |||
|
|
|||
There was a problem hiding this comment.
ESLint v9 では、このように無効な無効化コメントを検知できるようになりました。
s-sasaki-0529
commented
Dec 16, 2024
packages/smarthr-ui/src/components/Dialog/MessageDialog/MessageDialogContentInner.tsx
Outdated
Show resolved
Hide resolved
…eDialogContentInner.tsx
s-sasaki-0529
commented
Dec 16, 2024
| @@ -97,7 +97,7 @@ type Props<T extends React.ElementType> = PropsWithChildren< | |||
| > & | |||
| ComponentPropsWithoutRef<T> | |||
|
|
|||
| const _Cluster = <T extends React.ElementType = 'div'>( | |||
| const ActualCluster = <T extends React.ElementType = 'div'>( | |||
There was a problem hiding this comment.
ここリネームしてます。
ESLint のバージョンアップによって、「Hooks を使えるのは React コンポーネントだけだぞ」ってルールに引っかかりました。
これはちゃんと React コンポーネントなんですが、どうやらコンポーネントならキャメルメースの命名のはずだと疑われてしまったので、ちゃんとキャメルメースを満たす名前に変えました。
s-sasaki-0529
commented
Dec 16, 2024
packages/smarthr-ui/src/components/Layout/Reel/Reel.stories.tsx
Outdated
Show resolved
Hide resolved
s-sasaki-0529
commented
Dec 16, 2024
s-sasaki-0529
requested review from
moshisora,
uknmr and
a team
and removed request for
a team
nabeliwo
approved these changes
Dec 23, 2024
Storybook コードも ESLint の対象にするって方針だった気がするので、今が正解にも見えますが別途調整します！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
社内向けドキュメント
eslint v9 と Flat Config と SmartHR
概要
eslint-plugin-configおよびeslint-config-smarthrの v9 化・FlatConfig 化 が完了したので、本リポジトリでも対応します。変更内容
確認方法
コードをチェックアウトし、以下コマンドを実行することで ESLint の設定を確認できます。ざっと見て問題無さそうであればとりあえず良さそう。
以下を確認してます。
pnpm ui lint:eslintが意図通り実行されうこと