feat: AppHeader コンポーネントを追加 #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
nabeliwo
requested review from
yuzuru-akiyama,
masa0527,
Tokky0425,
uknmr and
versionfive
and removed request for
a team,
yuzuru-akiyama and
masa0527
nabeliwo
force-pushed
the
add-app-header
branch
from
8d7b290 to
c15e29d
Compare
Tokky0425
reviewed
Dec 23, 2024
|
|
||
| import { AppLauncher } from './AppLauncher' | ||
| import { Navigation } from './Navigation' | ||
| import { UserInfo } from './UserInfo.tsx' |
There was a problem hiding this comment.
ほんまですね…！修正しました！ 920cb76
nabeliwo
force-pushed
the
add-app-header
branch
from
ad7d867 to
0edb432
Compare
nabeliwo
force-pushed
the
add-app-header
branch
from
0edb432 to
920cb76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
🍐
概要
AppHeader コンポーネントを追加したい。
AppHeader コンポーネントは、Header と AppNavi を結合したコンポーネントです。各プロダクトのヘッダーの表示を共通化させるために存在します。
詳しくは コンポーネントの README を参照してください。
変更内容
AppHeader の追加
確認方法
Storybook で確認してください。
https://63d0ccabb5d2dd29825524ab-vwkuynyozq.chromatic.com/?path=/story/navigation%EF%BC%88%E3%83%8A%E3%83%93%E3%82%B2%E3%83%BC%E3%82%B7%E3%83%A7%E3%83%B3%EF%BC%89-appheader--playground