Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schematics): add "eslint:recommended" to eslintrc file #446

Merged
merged 4 commits into from
May 16, 2023
Merged

refactor(schematics): add "eslint:recommended" to eslintrc file #446

merged 4 commits into from
May 16, 2023

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Apr 30, 2023

should close upon completion #179.

@bbortt
Copy link
Collaborator

bbortt commented May 4, 2023

@naaajii I appreciate the contribution, but there is some more that needs to be done (see the action results) 😉 this code is kinda messy, if you aren't used to it. let me know if you need any help.

@naaajii
Copy link
Contributor Author

naaajii commented May 4, 2023

@bbortt thanks for reminding me, I didn't finish this off where. I will defi appreciate if you can provide me some heads up against what should we do ahead, I did run it with --fix which only fixed two or three issues, what should go with no-undef & bout no-unused-vars instead of it omitting errors should it be warnings?

@bbortt
Copy link
Collaborator

bbortt commented May 5, 2023

I did run it with --fix which only fixed two or three issues

I know, it's a shame.. must do almost everything by handwork. that's why I've never started it.

instead of it omitting errors should it be warnings

that sounds like a good idea - then we would at least be aware of it. and could resolve them one by one.

@naaajii
Copy link
Contributor Author

naaajii commented May 5, 2023

I have updated the PR!

Copy link
Collaborator

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would merge this after #453.

@bbortt bbortt enabled auto-merge (rebase) May 16, 2023 19:27
@bbortt bbortt merged commit 4ac0854 into kuhnroyal:release May 16, 2023
@naaajii naaajii deleted the prettier-recommended-rule branch May 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants