-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff20241218 fixing all but one ruff lint #693
Open
evelynmitchell
wants to merge
19
commits into
kyegomez:master
Choose a base branch
from
evelynmitchell:ruff20241218
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -111,8 +111,7 @@ | |||
history: List[Dict[str, Any]] = field(default_factory=list) | |||
|
|||
|
|||
hints = get_type_hints(func) | |||
|
|||
hints = get_type_hints(func) # noqa: F821 |
Check failure
Code scanning / Pyre
Unbound name Error
Unbound name [10]: Name func is used but not defined in the current scope.
@@ -109,9 +109,12 @@ | |||
cuda_available = torch.cuda.is_available() | |||
if cuda_available: | |||
gpu_info = torch.cuda.get_device_name(0) | |||
return cuda_available, gpu_info | |||
return cuda_available, gpu_info |
Check failure
Code scanning / Pyre
Uninitialized local Error test
Uninitialized local [61]: Local variable gpu\_info is undefined, or not always defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing ruff lint
📚 Documentation preview 📚: https://swarms--693.org.readthedocs.build/en/693/