feat: control idle state to set min temperature

kyle-seongwoo-jun · Feb 21, 2024 · d752249 · d752249
1 parent 7d08393
commit d752249
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 33 deletions.
diff --git a/src/homebridge/electric-mat.device.ts b/src/homebridge/electric-mat.device.ts
@@ -94,12 +94,12 @@ export default class ElectricMat {
       .onGet(this.getTemperature.bind(this));
 
     // target temperature
-    const { heat } = device.functions;
+    const { heatRange } = device.functions;
     heater.getCharacteristic(HeatingThresholdTemperature)
       .setProps({
-        minValue: heat.min,
-        maxValue: heat.max,
-        minStep: heat.step,
+        minValue: heatRange.min,
+        maxValue: heatRange.max,
+        minStep: heatRange.step,
       })
       .onGet(this.getTemperature.bind(this))
       .onSet(this.setTemperature.bind(this));
@@ -164,12 +164,12 @@ export default class ElectricMat {
       .onSet(this.setHeatingState.bind(this));
 
     // target temperature
-    const { heat } = device.functions;
+    const { heatRange } = device.functions;
     thermostat.getCharacteristic(TargetTemperature)
       .setProps({
-        minValue: heat.min,
-        maxValue: heat.max,
-        minStep: heat.step,
+        minValue: heatRange.min,
+        maxValue: heatRange.max,
+        minStep: heatRange.step,
       })
       .onGet(this.getTemperature.bind(this))
       .onSet(this.setTemperature.bind(this));

diff --git a/src/navien/navien.api.ts b/src/navien/navien.api.ts
@@ -158,38 +158,26 @@ export class NavienApi {
     });
   }
 
-  public setTemperature(device: Device, temperature: number) {
-    const {
-      Properties: {
-        registry: {
-          attributes: {
-            functions: {
-              heatControl,
-            },
-          },
-        },
-      },
-    } = device;
-
+  public setTemperature(device: Device, temperature: number, range: { min: number; max: number; step: number }) {
     // validate temperature
-    const { rangeMin, rangeMax, unit } = heatControl;
-    if (temperature < rangeMin || temperature > rangeMax) {
-      throw new Error(`Temperature must be between ${rangeMin} and ${rangeMax}. current: ${temperature}`);
+    const { min, max, step } = range;
+    if (temperature < min || temperature > max) {
+      throw new Error(`Temperature must be between ${min} and ${max}. current: ${temperature}`);
     }
-    if (temperature % parseFloat(unit) !== 0) {
-      throw new Error(`Temperature must be multiple of ${unit}. current: ${temperature}`);
+    if (temperature % step !== 0) {
+      throw new Error(`Temperature must be multiple of ${step}. current: ${temperature}`);
     }
 
     return this.controlDevice(device, {
       heater: {
         left: {
-          enable: true,
+          enable: temperature > min,
           temperature: {
             set: temperature,
           },
         },
         right: {
-          enable: true,
+          enable: temperature > min,
           temperature: {
             set: temperature,
           },

diff --git a/src/navien/navien.device.ts b/src/navien/navien.device.ts
@@ -57,14 +57,14 @@ export class NavienDevice {
     const { heatControl } = functions;
 
     const step = parseFloat(heatControl.unit);
-    const heat = {
+    const heatRange = {
       min: heatControl.rangeMin - step,
       max: heatControl.rangeMax,
       step: step,
     };
 
     return {
-      heat,
+      heatRange,
     };
   }
 
@@ -81,8 +81,8 @@ export class NavienDevice {
   }
 
   get isIdle() {
-    const { heat } = this.functions;
-    return this._power && this._temperature === heat.min;
+    const { heatRange } = this.functions;
+    return this._power && this._temperature === heatRange.min;
   }
 
   get temperature() {
@@ -114,7 +114,7 @@ export class NavienDevice {
   }
 
   setTemperature(temperature: number) {
-    return this.api.setTemperature(this.json, temperature);
+    return this.api.setTemperature(this.json, temperature, this.functions.heatRange);
   }
 
   dispose() {