Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuerRef to kyma-tls-cert certificate #1528

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

videlov
Copy link
Contributor

@videlov videlov commented Dec 9, 2024

Description

Changes proposed in this pull request:

  • Add issuerRef to kyma-tls-cert certificate

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@videlov videlov requested review from a team as code owners December 9, 2024 12:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
Copy link
Contributor

@Ressetkk Ressetkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the issuer ref is static, so LGTM.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 9, 2024
@videlov videlov merged commit 2bf9c22 into kyma-project:main Dec 10, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants