Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of the 3rd party payload #236

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Validation of the 3rd party payload #236

wants to merge 7 commits into from

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Dec 17, 2024

Description

Changes proposed in this pull request:

  • verify if the runtimeID, that comes from external service Compass is in the correct UUID format
  • validate the URL of the token to the Compass Connector to ensure it points to the SAP domain
  • perform a sanity check on the Token itself

Related issue(s)
#54

@mvshao mvshao requested a review from a team as a code owner December 17, 2024 07:39
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2024
@mvshao mvshao added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 17, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Dec 17, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvshao @kyma-bot