fix: invalid name in kuttl migrate command (#480)

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
kyverno · Nov 24, 2023 · 2ec8aa0 · 2ec8aa0
1 parent dec8822
commit 2ec8aa0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.release-notes/main.md b/.release-notes/main.md
@@ -23,3 +23,4 @@ Release notes for `TODO`.
 ## :wrench: Fixes :wrench:
 
 - Fixed a kuttl migration failure in case of unsupported file name
+- Fixed a potential invalid name when migrating a kuttl test step
diff --git a/pkg/commands/kuttl/migrate/command.go b/pkg/commands/kuttl/migrate/command.go
@@ -146,7 +146,7 @@ func migrate(out io.Writer, path string, resource unstructured.Unstructured) (me
 				return nil, err
 			}
 			if step.GetName() == "" {
-				step.SetName(groups[2])
+				step.SetName(strings.ReplaceAll(groups[2], "_", "-"))
 			}
 			return step, nil
 		case "TestAssert":
Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,3 +23,4 @@ Release notes for `TODO`.
		## :wrench: Fixes :wrench:

		- Fixed a kuttl migration failure in case of unsupported file name
		- Fixed a potential invalid name when migrating a kuttl test step