Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metrics: fix metric base type, Add report interface for report and support functions #17

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

lalmei
Copy link
Owner

@lalmei lalmei commented Oct 17, 2024

Refactors the metrics to fix the base type issue and adds a report interface with support functions.

if not path.exists():
logger.error(f"Error: Path not found: {path}")
raise typer.Exit(code=1)
# project = Project(path=path, console=console)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this commented out code.

# analyze github or gitlab pull/merge requests, issues
if not repo_token:
raise ValueError(
"token required for repository analysis of pull requests and issues, you can define the env variable GITHUB_TOKEN"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long (130 > 79 characters)

@app.command(no_args_is_help=True)
def extract(
ctx: Context,
path: Path = typer.Option(Path.cwd(), help="path or url to package source code"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long (85 > 79 characters)

Copy link

codeclimate bot commented Oct 17, 2024

Code Climate has analyzed commit fbf3661 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2
Clarity 1

The test coverage on the diff in this pull request is 71.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 43.2%.

View more on Code Climate.

@lalmei lalmei marked this pull request as ready for review October 17, 2024 00:29
@lalmei lalmei merged commit 18a37ca into main Oct 17, 2024
6 checks passed
@lalmei lalmei deleted the Virtual-branch-2375619231 branch October 17, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant