add unasync to project dependencies #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Dec 10, 2024
libs/elasticsearch/pyproject.toml
Outdated
|
|
||
| [tool.poetry.group.codegen.dependencies] | ||
| unasync = "^0.6.0" | ||
| isort = "^5.13.2" |
There was a problem hiding this comment.
I did not notice that the last time, but should we remove isort, as ruff includes it already?
There was a problem hiding this comment.
I guess we should. Didn't know ruff sorts, I'll switch to that.
miguelgrinberg
force-pushed
the
add-unasync-isort-to-project
branch
from
f415591 to
09bd446
Compare
pquentin
reviewed
Dec 10, 2024
miguelgrinberg
changed the title
pquentin
reviewed
Dec 11, 2024
|
Yes, indirectly it did, but for a good reason. The tests were designed to work with the <=8.15 Python client, which used knn for hybrid search. We updated the 8.16 client to use a retriever query instead, so now these tests need updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unasync and isort to pyproject.toml. This was missed in the unasync PR.