Fix deleting NSSDB objects #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
requested changes
Dec 11, 2024
The SKIP_ATTRIBUTES are not stored in the NSS DB. When constructing the queries, these need to be skipped otherwise they will reference non-existing table columns and fail on the DB level. But the application is asking for them so we need to mock the default values back when returning from fetch(). This demonstrated when destroying a token objects, which checks if the object has the CKA_DESTROYABLE attribute. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
This allows to fill specific attributes with the defined default value for the specific object type. If the object does not have a default value for the requested attribute nothing it set on the object. Signed-off-by: Simo Sorce <[email protected]>
|
Rebased on main and pushed a patch that addresses my request. |
simo5
approved these changes
Dec 11, 2024
Jakuje
commented
Dec 11, 2024
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly my naive approach. Not sure if there is a better way or better place where this could be handled.