Improve output length checking for FIPS indicators in AES/HMAC code #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
The check_mac_fips_indicators() won't do anything for the CMACs, as the cmac implementation in FIPS provider does not implement this parameter. The AES key with SIGN/VERIFY flags was also not marked correctly as FIPS valid so any CMAC operation on that given key caused the FIPS indicator failure. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
jvdsn
reviewed
Jan 3, 2025
| * > For most applications, a value for Tlen that is at least 64 | ||
| * should provide sufficient protection against guessing attacks. | ||
| */ | ||
| self.fips_approved = Some(self.maclen >= (32 / 8)); |
There was a problem hiding this comment.
Is it intended to use 32 or 64 bits here? The comment seems to reference 64 bits but the code uses 32 bits.
|
For what it's worth, if you're ever thinking about certifying KMAC, OpenSSL < 3.4 doesn't have a check. OpenSSL 3.4+ should have a check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues:
check_mac_fips_indicators()won't do anything for the CMACs, as the cmac implementation in FIPS provider does not implement the fips indicator OSSL_PARAM.I am still not sure about the GCM as the specs are vague. Putting 64b for now.