Add support for RSA PSS and OAEP padding schemes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
changed the title
simo5
force-pushed
the
rsa_pss_oaep
branch
2 times, most recently
from
7fb96f1 to
37552c0
Compare
simo5
changed the title
Jakuje
reviewed
Mar 10, 2024
OpenSSL does not consider the padding type except for special TLS padding, so even though it should know that PKCS1 1.5 padding implies the output can't be larger than modulus length - 11, the decrypt function requires a full modulus long output buffer. Use a support buffer to bridge the required len if the application provides a buffer that is long enough according to the PKCS#11 spec but openssl considers too short. Signed-off-by: Simo Sorce <[email protected]>
This allows in future to support different implementations haveing support for different mechanisms for the same algorithm family. Signed-off-by: Simo Sorce <[email protected]>
|
I should have addressed all the items except for mgf1_to_digest_buf() name one. |
Jakuje
approved these changes
Mar 12, 2024
Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
Jakuje
approved these changes
Mar 12, 2024
Uses some vectors obtained from https://github.com/pyca/cryptography/blob/main/vectors/cryptography_vectors/asymmetric/RSA Signed-off-by: Simo Sorce <[email protected]>
Reuse the existing rsa_import function already use for private keys. Move the constants in the implementation where they belong as the supported key sizes depend on the implementation used. Change the minimum key size in the fips implementation to reflect the actual minimum for that implemenation. Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
|
Merged! @Jakuje thanks for the thorough reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Rsa code to allow PSS and OAEP mechanisms