Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added various images for light and dark mode also fixed svg issue. #6120

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Added various images for light and dark mode also fixed svg issue. #6120

wants to merge 31 commits into from
+1,829 −128

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Dec 10, 2024 •
edited
Loading

Description

I have fixed the image issue in which their was a png file within the svg file also I have updated the wrong className so that the necessary property of the CSS is applied.

This PR fixes #5467

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Ajay-singh1 Ajay-singh1 changed the title Removed unnecessary boolean condition Fix image issue Dec 10, 2024
@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit 997abdb at: https://6758565d60435f6227f0395a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit cb06ee8 at: https://675862cf3aba0800813f5053--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit bf31c1c at: https://675a4807577d84cf83b2cb1c--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 12, 2024 02:27
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit a223d57 at: https://675a4cc74b7dd2c9047354f6--layer5.netlify.app

@Ajay-singh1
Work Around Fix
9dd328c 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Fix Lint
1d54ea2 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 1d54ea2 at: https://675a55026eb9b79af7a67bbf--layer5.netlify.app

@Ajay-singh1
Fixed the semicolon
94c84b3 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 94c84b3 at: https://675a5c2e4b7dd2dcdf735178--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as ready for review December 12, 2024 04:48
@Ajay-singh1
Copy link
Contributor Author

@leecalcote Indeed their was a PNG File within this SVG I have fixed it.

@Ajay-singh1
Copy link
Contributor Author

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

Final Result.

@l5io
Copy link
Contributor

l5io commented Dec 13, 2024

🚀 Preview for commit ce4ee09 at: https://675ba2e46168b35f98b78323--layer5.netlify.app

@mdkaifansari04
Copy link
Contributor

Looks good @Ajay-singh1, dark and light svg is also working 👍

@vishalvivekm
Copy link
Contributor

@Ajay-singh1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

sudhanshutech
sudhanshutech requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@sudhanshutech sudhanshutech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ajay-singh1 why this light mode for the aws only? not other ones like GCP and kubernetes? And why only on the one part and not on the whole page we should use dark and light mode images?

@Ajay-singh1
Copy link
Contributor Author

Ajay-singh1 commented Dec 19, 2024 •
edited
Loading

@sudhanshutech Done!

@l5io
Copy link
Contributor

l5io commented Dec 19, 2024

🚀 Preview for commit d10feb7 at: https://6763b7a7cbfd661d050ecd80--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 21, 2024

🚀 Preview for commit f42e9b4 at: https://6766bd0b44e08b4fb42280b7--layer5.netlify.app

@Ajay-singh1
Revert the changes
d114294 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1 Ajay-singh1 changed the title Added various images for dark and light mode also fixed svg issue Fixed the SVG Image problem and updated wrong CSS class names. Dec 21, 2024
@l5io
Copy link
Contributor

l5io commented Dec 21, 2024

🚀 Preview for commit d114294 at: https://6766e34a6ec7d85eb180657d--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 22, 2024 00:22
@Ajay-singh1 Ajay-singh1 changed the title Fixed the SVG Image problem and updated wrong CSS class names. Added various images for light and dark mode also fixed svg issue. Dec 22, 2024
@l5io
Copy link
Contributor

l5io commented Dec 22, 2024

🚀 Preview for commit 6e4376d at: https://676769966d04b0ed9f3a22a5--layer5.netlify.app

@Ajay-singh1
Added Images
88673e1 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added Images
630a8f9 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added Images
a1c0ae7 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added SVG Images for Dark theme in Catalog Card Images
bd12779 
Signed-off-by: Ajay Singh <[email protected]>
@sudhanshutech
Copy link
Member

@Ajay-singh1
Let's discuss this during the website call today at 6:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@Ajay-singh1
Updated the 3d spinning on the Kanvas page to use dark images when th…
85366d7 
…e theme is dark mode

Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Updated the 3d spinning on the catalog page to use dark images when t…
1b26c9b 
…he theme is dark

Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Removed PNG within the SVG File
01dab03 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Removed PNG within the SVG
6f4e6ab 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added a dark image for cluster
30dc60f 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Renamed File
7764990 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added Images and removed unwanted code from the svg file
7ddb967 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Removed PNG file within the SVG File
55f4e76 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Added the missing tag
edfdcf4 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1
Renamed wrong file name
be37c8a 
Signed-off-by: Ajay Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@sudhanshutech sudhanshutech sudhanshutech requested changes

Assignees
No one assigned
Labels
project/kanvas
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PNG masquerading as an SVG
7 participants
@Ajay-singh1 @l5io @mdkaifansari04 @vishalvivekm @leecalcote @Pratik-050 @sudhanshutech