Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port to *Lua* v5.4 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stevenxxiu
Copy link

@stevenxxiu stevenxxiu commented Feb 3, 2024

Thanks for the plugin! I ported this to Lua v5.4, so I can use https://github.com/3rd/image.nvim for https://github.com/benlubas/molten-nvim.

I switched to the CFFI library q66/cffi-lua: A portable C FFI for Lua 5.1+.

I tested this via make test. All tests pass.

I haven't tested this on GraphicsMagick, but made the same changes.

Hope you have time to look at this.

@stevenxxiu
Copy link
Author

I just realized that Neovim is still on Lua v5.1. So in that case this PR doesn't need to be merged, at least not now.

@leafo
Copy link
Owner

leafo commented Feb 3, 2024

I won't be able to accept this PR as is, this library is intentionally designed to work in environments with LuaJIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants