Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup deprecations #89

Merged
merged 2 commits into from
Nov 24, 2024
Merged

chore: cleanup deprecations #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e785b6
.
kim-em Nov 23, 2024
3cc4cd1
chore: remove deprecated `html!` tactic
Vtec234 Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ProofWidgets/Component/HtmlDisplay.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@ def elabHtmlCmd : CommandElab := fun
stx
| stx => throwError "Unexpected syntax {stx}."

/-- The `html!` tactic is deprecated and does nothing.
If you have a use for it,
please open an issue on https://github.com/leanprover-community/ProofWidgets4. -/
@[deprecated]
syntax (name := htmlTac) "html! " term : tactic

open Tactic in
@[tactic htmlTac]
def elabHtmlTac : Tactic | _ => pure ()

end HtmlCommand
end ProofWidgets

Expand Down
15 changes: 0 additions & 15 deletions ProofWidgets/Presentation/Expr.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,21 +81,6 @@ structure GetExprPresentationParams where
name : Name
deriving RpcEncodable

@[server_rpc_method]
def getExprPresentation : GetExprPresentationParams → RequestM (RequestTask Html)
| { expr := ⟨expr⟩, name } => RequestM.asTask do
let ci := expr.ci
if !exprPresenters.hasTag ci.env name then
throw <| RequestError.invalidParams s!"The constant '{name}' is not an Expr presenter."
match evalExprPresenter ci.env ci.options name with
| .ok p =>
expr.runMetaM p.present
| .error e =>
throw <| RequestError.internalError s!"Failed to evaluate Expr presenter '{name}': {e}"

-- https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/deprecation.20warning.20from.20ProofWidgets
attribute [deprecated] getExprPresentation

structure ExprPresentationProps where
expr : WithRpcRef ExprWithCtx
deriving RpcEncodable
Expand Down