Create Toy App #16
Open
Create Toy App #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App is able to fetch toys from backend API. We can also add new toys to our backend as well as update the likes.
stephenmckeon
approved these changes
May 23, 2024
Comment on lines
+13
to
+32
| const createHTMLElement = (tag, className, textContent, src, id) => { | ||
| const element = document.createElement(tag) | ||
| if(className) element.className = className | ||
| if(textContent) element.textContent = textContent | ||
| if(src) element.src = src | ||
| if(id) element.id = id | ||
| return element | ||
| } | ||
|
|
||
| const renderToyCard = (toy) => { | ||
| const div = createHTMLElement('div', 'card') | ||
| div.appendChild(createHTMLElement('h2', null, toy.name)) | ||
| div.appendChild(createHTMLElement('img', 'toy-avatar', null,toy.image)) | ||
| div.appendChild(createHTMLElement('p', null, `${toy.likes} Likes`)) | ||
| const button = createHTMLElement('button', 'like-btn', `Like ❤️`, null, `${toy.id}`) | ||
| button.style.cursor = 'pointer' | ||
| button.addEventListener('click', handlePATCHLikes) | ||
| div.appendChild(button) | ||
| toyCollection.appendChild(div) | ||
| } |
There was a problem hiding this comment.
I appreciate the idea, but it's certainly confusing. Contrary to the saying, sometimes more is less. Sacrificing readability to make something shorter is always a tough dilemma, but I think in this case being more explicit is the way to go. But again, I love the creativity.
Comment on lines
+41
to
+42
| e.target[0].value = '' | ||
| e.target[1].value = '' |
There was a problem hiding this comment.
Suggested change
| e.target[0].value = '' | |
| e.target[1].value = '' | |
| e.target.reset() |
| }) | ||
| .then(res => res.json()) | ||
| .then(data => updateLikes(data, event)) | ||
| .catch(handleError) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App is able to fetch toys from backend API. We can also add new toys to our backend as well as update the likes.