Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Build on Node >= 12 #108

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Fix Broken Build on Node >= 12 #108

merged 2 commits into from
Dec 30, 2020

Conversation

isopropylcyanide
Copy link
Contributor

@isopropylcyanide isopropylcyanide commented Dec 6, 2020

Fixes broken build on Node >= 12

Issue

  • During Npm Build
    image

image

  • Gulp@<4.0 depends on graceful-fs@^3.0.0. It monkeypatches Node.js fs module.
  • Hence, with Node JS >= 12, it doesn't work. Solution is to force the FS resolution

@isopropylcyanide isopropylcyanide changed the title Connectivity Error FIx | Incompatible Graceful FS version in older gulp Connectivity Error Fix | Incompatible Graceful FS version Dec 6, 2020
@isopropylcyanide isopropylcyanide changed the title Connectivity Error Fix | Incompatible Graceful FS version Fix Connectivity Error | Incompatible Graceful FS version Dec 6, 2020
@isopropylcyanide isopropylcyanide changed the title Fix Connectivity Error | Incompatible Graceful FS version Fix Broken Build on Node >= 12 Dec 6, 2020
Comment on lines +40 to +42
"resolutions": {
"graceful-fs": "^4.2.4"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you already upgraded to Gulp version 4. From the Documentation, I see that resolutions are only needed if you want to work with Node > 12 and Gilp 3.x.x. Can you please try to remove it and see what happens?? Thanks for the PR.. 🚀

Copy link
Contributor Author

@isopropylcyanide isopropylcyanide Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for pointing it out. The build works as expected. I've removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Will merge it soon!! And sorry for the delay in getting back to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot :)

@EfstathiadisD EfstathiadisD merged commit c68cd96 into lensesio:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants