AWS - [Security] Don't throw exception with secret value in message #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase/rework of #23 by @adrianisk against the latest version of the code base.
Original PR description:
Summary
This change prevents the library from throwing an exception that contains the secret text in the exception message when using the AWS SecretsManager provider. While doing some local testing I noticed the thrown exception, along with the secret, will end up in Kafka Connect's logs which isn't great. To fix I updated the code to catch the
JsonParseException
which contains the secret value, and throw an exception with a generic parsing error message in its place.Test
I added a unit test to verify, prior to the fix it failed with