Chore/dep check #66
Merged
Chore/dep check #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsloan
force-pushed
the
chore/dep-check
branch
from
957a1b3 to
de27039
Compare
davidsloan
force-pushed
the
chore/dep-check
branch
from
de27039 to
e4fb842
Compare
stheppi
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java jars usually come packaged with a META-INF/maven directory, known as the maven descriptor, which contains information about all dependencies packaged within. As we were using SBT we were not generating a maven descriptor, and only passing along the descriptors from some of our dependent jars. This was causing an issue that the descriptor reported some of our components packaged within as out-of-date.
This PR adds the creation of a maven descriptor director during the compile stage, which is packaged into the final jar via sbt assembly. We also avoid packaging the maven descriptors from our dependencies as these are unreliable.
I have verified that this works by looking at the dependency report and I can see that
json-smartis no longer reported as an old version.