All the changes #59
Open
All the changes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix validity check to avoid no sleep condition
Added vehicle_is_charging and vehicle_is_driving methods
Renamed Functions and added usage to drive checks
Fix lephisto#51 Invalid Field Format
fix validity check to avoid no sleep condition
Added vehicle_is_charging and vehicle_is_driving methods
Added offline check to reduce polling.
Patch to prevent crashes when hostname lookups fail
Using best practices for cached layers, removed unneeded dependencies, and simply copied in local files (rather than pulling the project) which improves DX, speeds build, and fixes caching problems.
If you have multiple cars, you can now easily run multiple scrapers.
refactor(docker): use data/ rather than rely on /opt
Refactor/docker compose
Note is in the install script
gundalow
reviewed
Jul 25, 2019
| ```bash | ||
| # Enter your email and password to your tesla.com account | ||
| teslaEmail="" | ||
| teslaPassword="" | ||
|
|
There was a problem hiding this comment.
Missing git clone (and possibly swapping branch)?
Suggested change
| git clone https://github.com/lephisto/tesla-apiscraper.git | |
| cd tesla-apiscraper | |
| # Swap to the latest stable, version, such as: | |
| git checkout v2019.5 |
Co-Authored-By: John R Barker <[email protected]>
|
I will test this next days and merge if everything fine.. |
|
Any updates on the merge? I’m waiting in the wings for the green light to pull it and use it :) Thanks @lephisto for everything! |
|
Sorry, I was out for some business, I will dig into this next days. promise :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an updated version of the scraper running on Lunars repo, with many more changes to come
https://github.com/lunars/tesla-apiscraper