Add prettier, specify files for npm publish #11
Conversation
There was a problem hiding this comment.
@perry-mitchell Thanks for your involvement!
Just a couple of issues that I have with the PR.
Also, please run npm run format after the rule changes so that all the code is formatted properly.
|
@levansuper Updated as per your requests! I re-formatted the code and added |
.editorconfig
Outdated
|
|
||
| [{package.json,package-lock.json}] | ||
| indent_size = 2 | ||
| indent_style = space |
There was a problem hiding this comment.
Let's not use this please. This lib is not intended be opened in the editor.
There was a problem hiding this comment.
I'm not sure I understand.. How do you edit the source code if not in an editor?
There was a problem hiding this comment.
Editorconfig is a standard for any editor to help conform to a specific set of requirements. It'd probably help avoid simple stylistic issues for future PRs.
But if you don't think it's beneficial to this library I can remove it.
There was a problem hiding this comment.
The IDEs can pick the config from .prettierrc and it will be prettified on commits anyway, so I think this is not necessary.
Hello! Nice library. I'm using it myself, and wanted to help out.
I've added fixes to address #8 and #9. Basic prettier setup with a
formatcommand and git hooks to help do formatting automatically when you commit. I chose some basic prettier options to hopefully match your style, such as 4 space indent and single quotes. Please let me know if you'd have me change anything and I can update them for the PR.