Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: incremental updates #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: incremental updates #45

wants to merge 1 commit into from

Conversation

lewis6991
Copy link
Owner

Updates no longer refresh every handler

Updates no longer refresh every handler
@justinmk
Copy link

justinmk commented Jun 24, 2023

I noticed that / search on some files (filetype=css) can hang for a few seconds, any chance this PR is related?

@lewis6991
Copy link
Owner Author

How do you mean related? Are you running this PR?

I'm not sure if I'll merge this, because we basically need a full redraw anyway on any fold changes, so the benefits of incremental updates is pretty small.

@justinmk
Copy link

How do you mean related? Are you running this PR?

I mean is this PR intended to fix related behavior? Haven't tried this PR.

@lewis6991
Copy link
Owner Author

No. This plugin is very filetype agnostic, so its interesting your seeing issues with specific filetypes.

If you can provide a repro, I can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants