fix comments

include/rocksdb/utilities/cache_dump_load.h

@@ -67,8 +67,8 @@ class CacheDumpReader {
 // dump or load process related control variables can be added here.
 struct CacheDumpOptions {
   SystemClock* clock;
-  // Max duration time in ms for dumper or loader
-  uint64_t max_duration_time_ms = 0;
+  // Deadline for dumper or loader in microseconds
+  std::chrono::microseconds deadline = std::chrono::microseconds::zero();
   // Max size bytes for dumper or loader
   uint64_t max_size_bytes = 0;
 };

unreleased_history/new_features/cache_dumper.md

@@ -1 +1 @@
-Added two options `max_duration_tims_ms` and `max_size_bytes` for CacheDumper to exit early
+Added two options `deadline` and `max_size_bytes` for CacheDumper to exit early

utilities/cache_dump_load_impl.cc

@@ -69,16 +69,11 @@ IOStatus CacheDumperImpl::DumpCacheEntriesToWriter() {
   }
   clock_ = options_.clock;
 
+  deadline_ = options_.deadline;
+
   // Set the sequence number
   sequence_num_ = 0;
 
-  // Set deadline
-  if (options_.max_duration_time_ms > 0) {
-    deadline_ts_ = clock_->NowMicros() + options_.max_duration_time_ms * 1000;
-  } else {
-    deadline_ts_ = std::numeric_limits<uint64_t>::max();
-  }
-
   // Dump stage, first, we write the hader
   IOStatus io_s = WriteHeader();
   if (!io_s.ok()) {
@@ -132,8 +127,11 @@ CacheDumperImpl::DumpOneBlockCallBack(std::string& buf) {
     }
 
     uint64_t timestamp = clock_->NowMicros();
-    if (timestamp > deadline_ts_) {
-      return;
+    if (deadline_.count()) {
+      std::chrono::microseconds now = std::chrono::microseconds(timestamp);
+      if (now >= deadline_) {
+        return;
+      }
     }
 
     CacheEntryRole role = helper->role;

utilities/cache_dump_load_impl.h

@@ -124,7 +124,7 @@ class CacheDumperImpl : public CacheDumper {
   // filtering.
   std::set<std::string> prefix_filter_;
   // Deadline for dumper in microseconds.
-  uint64_t deadline_ts_;
+  std::chrono::microseconds deadline_;
   uint64_t dumped_size_bytes_;
 };