-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for RetroArch 1.19.2] udev: Update and rename Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony DualShock 4 Controller.cfg
-- Merge DualShock 4 v1 and v2
#1168
Open
davidhedlund
wants to merge
44
commits into
libretro:master
Choose a base branch
from
davidhedlund:patch-48
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input_device_display_name = "Sony DualShock 4 Controller"
davidhedlund
changed the title
Update Sony-PlayStation4-DualShock4v2-Controller.cfg
udev: Update Sony-PlayStation4-DualShock4v2-Controller.cfg
Aug 6, 2024
…ive Entertainment Wireless Controller.cfg
davidhedlund
changed the title
udev: Update Sony-PlayStation4-DualShock4v2-Controller.cfg
udev: Update and rename Sony-PlayStation4-DualShock4v2-Controller.cfg to Sony Interactive Entertainment Wireless Controller.cfg
Aug 18, 2024
davidhedlund
changed the title
udev: Update and rename Sony-PlayStation4-DualShock4v2-Controller.cfg to Sony Interactive Entertainment Wireless Controller.cfg
udev: Update and rename Aug 18, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
davidhedlund
changed the title
udev: Update and rename
[READY] udev: Update and rename Aug 20, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
input_l2_axis_label = "L2 Analog" input_r2_axis_label = "R2 Analog"
The udev driver depends on input_device, rather than input_vendor_id and input_product_id.
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1356" input_product_id = "2508"
# The files "Sony Interactive Entertainment Wireless Controller.cfg" and "Wireless Controller.cfg" should have identical content except for the input_device variable until they can be merged when this issue has been solved: [IMPORTANT feature request]: Support multiple input_device names for controller compatibility across Linux kernels - libretro/RetroArch#16907
davidhedlund
changed the title
[READY] udev: Update and rename
[READY] udev: Update and rename Aug 21, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a copy named Wireless Controller.cfg
input_device_display_name = "Sony DualShock 4 v2 Controller (USB)"
input_device_display_name = "Sony DualShock 4 v2 Controller (BlueTooth)"
# This file is enabled by default to let you use the controller via USB. However, if you prefer to use Bluetooth instead, you need to comment out input_vendor_id and input_product_id in this file and uncomment them in the "Wireless Controller.cfg" file. Both files cannot be active simultaneously.
# This file will be detected if BlueTooth is used but this file is disabled by default since "Sony Interactive Entertainment Wireless Controller.cfg" (USB) is enabled by default. However, if you prefer to use Bluetooth instead, you need to comment out input_vendor_id and input_product_id in this file and uncomment them in the "Sony Interactive Entertainment Wireless Controller.cfg" file. Both files cannot be active simultaneously. #input_vendor_id = "1356" #input_product_id = "2508"
# See libretro/RetroArch#6920 # RetroArch's in-app feature to create autoconfig files is flawed and will attempt to create the 2 lines : # input_l2_btn = "6" # input_r2_btn = "7" # Those 2 lines are a downgrade from the 2 following lines which additionally allow l2/r2 to be polled as analog axes :
# See libretro/RetroArch#6920 # RetroArch's in-app feature to create autoconfig files is flawed and will attempt to create the 2 lines : # input_l2_btn = "6" # input_r2_btn = "7" # Those 2 lines are a downgrade from the 2 following lines which additionally allow l2/r2 to be polled as analog axes :
# Analog indication verified in Remote RetroPad: Yes
It seems more straightforward for a single pull request to remove input_vendor_id from all udev files once we reach a consensus on the issue discussed in: libretro/RetroArch#16907
It seems more straightforward for a single pull request to remove input_vendor_id from all udev files once we reach a consensus on the issue discussed in: libretro/RetroArch#16907
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
input_device = "Wireless Controller"
Removed the final comments
davidhedlund
changed the title
[READY] udev: Update and rename
[READY] udev: Update and rename Aug 26, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a copy named Wireless Controller.cfg
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copy
davidhedlund
changed the title
[READY] udev: Update and rename
[WAIT] udev: Update and rename Sep 2, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copySony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copy
davidhedlund
changed the title
[WAIT] udev: Update and rename
[READY] udev: Update and rename Sep 4, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copySony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copy
Avoid input_vendor_id/input_product_id conflict. Support multiple input_device and input_device_display_name variables - libretro/RetroArch#16907
davidhedlund
changed the title
[READY] udev: Update and rename
[READY] udev: Update and rename Sep 4, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
. And create a Wireless Controller.cfg
copySony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
input_l2_axis_label = "L2 Trigger" input_r2_axis_label = "R2 Trigger"
davidhedlund
added a commit
to davidhedlund/retroarch-joypad-autoconfig
that referenced
this pull request
Sep 12, 2024
davidhedlund
changed the title
[READY] udev: Update and rename
[READY] udev: Merge DualShock 4 v1 and v2
Sep 12, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony Interactive Entertainment Wireless Controller.cfg
davidhedlund
changed the title
[READY] udev: Merge DualShock 4 v1 and v2
[READY] udev: Merge Sony Interactive Entertainment Wireless Controller (DualShock 4 v2) and Sony Computer Entertainment Wireless (DualShock 4 v1)
Sep 13, 2024
… DualShock 4 Controller.cfg
davidhedlund
changed the title
[READY] udev: Merge Sony Interactive Entertainment Wireless Controller (DualShock 4 v2) and Sony Computer Entertainment Wireless (DualShock 4 v1)
[READY] udev: Update and rename Sep 13, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony DualShock 4 Controller.cfg
-- Merge DualShock 4 v1 and v2
input_device = "Sony Interactive Entertainment Wireless Controller" input_device_display_name = "Sony Interactive Entertainment Wireless Controller (DualShock 4 v2)" input_vendor_id = "1356" input_product_id = "2508" input_device_alt1 = "Wireless Controller" input_device_display_name_alt1 = "Wireless Controller (DualShock 4 v2)" input_vendor_id_alt1 = "1356" input_product_id_alt1 = "2508" input_device_alt2 = "Sony Computer Entertainment Wireless Controller" input_device_display_name_alt2 = "Sony Computer Entertainment Wireless (DualShock 4 v1)" input_vendor_id_alt2 = "1356" input_product_id_alt2 = "1476"
RobLoach
requested changes
Sep 28, 2024
davidhedlund
changed the title
[READY] udev: Update and rename
[Ready for RetroArch 1.19.2] udev: Update and rename Oct 1, 2024
Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony DualShock 4 Controller.cfg
-- Merge DualShock 4 v1 and v2Sony-PlayStation4-DualShock4v2-Controller.cfg
to Sony DualShock 4 Controller.cfg
-- Merge DualShock 4 v1 and v2
input_device_alt2 = "Wireless Controller" input_device_display_name_alt2 = "Sony Dualshock 4 Wireless - 500 Million Limited Edition (DualShock 4 v2)" input_vendor_id_alt2 = "1356" input_product_id_alt2 = "2508" Thanks rob
Merged to Sony DualShock 4 Controller.cfg: libretro@479c341
Merge DualShock 4 v1 and v2
input_device_alt2 = "Sony Dualshock 4 Wireless - 500 Million Limited Edition"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_device_display_name
to distinguish the controllers