Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for ToddCoxeter function to_gap_string #118

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add functionality for ToddCoxeter function to_gap_string #118

merged 2 commits into from
Feb 6, 2023

Conversation

MTWhyte
Copy link
Contributor

@MTWhyte MTWhyte commented Feb 6, 2023

This PR adds functionality for the ToddCoxeter function to_gap_string.

I think the CI will fail until there is a release of libsemigroups which includes the PR which adds argument checking for the sidedness of the congruence.

@james-d-mitchell
Copy link
Member

Thanks @MTWhyte, please add some if statements to the tests to test the version of libsemigroups and test the behaviour if the version is 2.6.0 or higher, as mentioned here:

#108

@james-d-mitchell james-d-mitchell merged commit 2567087 into libsemigroups:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MTWhyte @james-d-mitchell