Fix build with system LLVM #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoodman
requested changes
Nov 23, 2022
| if(LLVM_LINK_LLVM_DYLIB) | ||
| set(llvm_libs LLVM) | ||
| else() | ||
| set(llvm_libs ${LLVM_AVAILABLE_LIBS}) |
There was a problem hiding this comment.
Still want llvm_map_components_to_libnames here, otherwise it starts to pull in things like LibEdit. In the past we've also faced linking issues with LLVM_AVAILABLE_LIBS having some things out-of-order.
There was a problem hiding this comment.
Yeah that's true, I had to disable LibEdit on the LLVM command line. I'll try to reproduce the linker error then and see if I can find the component. Generally it shouldn't be an issue to link to all LLVM libraries, unused things are ignored. I've been using this since LLVM 10 without issues related to out-of-order linking.
|
Will open a new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a vanilla LLVM there were some issues with the build (when using system libraries):
GFLAGS_USE_TARGET_NAMESPACEthe targetgflags::gflagsdoes not exist, not sure what vcpkg is doing different there, perhaps an older version?These issues were found when trying a superbuild without vcpkg.