Upgrade to LDK 0.0.117 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
main
branch
6 times, most recently
from
28237ee to
75e4182
Compare
tnull
reviewed
Sep 22, 2023
src/main.rs
Outdated
| @@ -979,7 +1014,7 @@ async fn start_ldk() { | |||
| peer_manager.disconnect_all_peers(); | |||
|
|
|||
| if let Err(e) = bg_res { | |||
| let persist_res = persister.persist("manager", &*channel_manager).unwrap(); | |||
| let persist_res = persister.write("", "", "manager", &channel_manager.encode()).unwrap(); | |||
There was a problem hiding this comment.
Let's use all them (sub-)namespace constants as we're exporting them for this purpose: https://docs.rs/lightning/0.0.117-alpha1/lightning/util/persist/index.html#constants
Also, let's introduce analog constants for the locally persisted data, e.g., for the outbound payments, spendable outputs, etc.
There was a problem hiding this comment.
Not sure what you want for the locally persisted data - do we really need to add a ton of consts for the repeated ""s? We already have consts for the keys (are you just suggesting renaming those?).
TheBlueMatt
force-pushed
the
main
branch
5 times, most recently
from
c7d4f85 to
5713d6e
Compare
optout21
reviewed
Oct 11, 2023
|
Thanks! Updated to LDK 0.0.117-final, should be good to land now. |
Since we now have a `Persist`er which is separate from our `FilesystemStore`, its useful to use different names to differentiate the two.
TheBlueMatt
force-pushed
the
main
branch
2 times, most recently
from
b324bdf to
88bd0ca
Compare
tnull
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.