Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zombierecovery: support MuSig2 to rescue Simple Taproot channels #141

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 15, 2024

Fixes #133.

@hsjoberg
Copy link

Thank you for taking your valuable time to fix P2TR support for zombierecovery, @guggero.

When running this PR and trying to do makeoffer, it seemingly get stuck with no feedback.

Input your cipher seed passphrase (press enter if your seed doesn't have a passphrase): [enter]

Anything I could do to get us more info about what's going on?

Cheers

@guggero
Copy link
Member Author

guggero commented Jun 28, 2024

Hey, thanks for testing. I assume you hit "enter" a second time, just to make sure it's not just a weird console/terminal behavior? If yes, is the process actively doing anything, do you see CPU usage?
The only thing that could take a while is matching the keys. But unless you have thousands and thousands of keys in both files, it shouldn't take more than a couple of minutes.

@guggero guggero force-pushed the zombierecovery-p2tr branch from 5cf62e8 to 6a3ec9a Compare June 28, 2024 15:32
@guggero guggero force-pushed the zombierecovery-p2tr branch from 6a3ec9a to b499b37 Compare August 7, 2024 15:44
@guggero
Copy link
Member Author

guggero commented Aug 7, 2024

I assume this works, as I haven't gotten any feedback yet stating otherwise. Going to merge, can always address issues later on.

@guggero guggero merged commit a25853f into master Aug 7, 2024
2 checks passed
@guggero guggero deleted the zombierecovery-p2tr branch August 7, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zombie recovery error error matching keys to script: address: must be a bech32 P2WPKH or P2WSH address
2 participants