Migration #98
Draft
Migration #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was wedged into the package's description, but it can just as well go here in the additional info.
Previously this was wedged into the package's description, but it can just as well go here in additional information.
We don't have the field 'see_alsos' in our dataset schema, so there is no point excluding it from being displayed in additional information.
Fix/german translation
Fix/fix footer cookie settings link
This helper converts a value into a form that can be used as a sort key - for example, it converts a group's display_name so that a list of groups can be sorted by display_name. Our group titles are multilingual, so we need to localise the value before this can be done.
When we try to get toolkit.request.environ while rebuilding the search index, we get a RuntimeError, 'Working outside of request context,' so we need to catch that here as well as the TypeError.
See this comment by Adrià for details: ckan/ckan-docker-base#86 (comment).
See this comment by Adrià for details: ckan/ckan-docker-base#86 (comment).
Fix/fix adding dataset to groups
Fix/fix terms of use url
On the group list and user pages, we get the member count for each group and we can display it. On the dataset groups tab, we don't have the member count for each group, so we should not display anything rather than falsely saying each group has no members.
…t-page Fix/group members display on dataset page
Fix/fix group list item
This is necessary if we are calling this helper while not actually in a request context.
If we get into a state where we have duplicate resources for the same filename (e.g. because we created a new resource for the filename but deleting the old resource failed), we must not delete resources by filename in the finalize step! If we do, we will delete both the new and the old resource for the filename. This method is already a lot simpler than it used to be, since CKAN no longer stores lots of old versions of resources in the database, so it's safe to change it to delete resources by id.
This will also clean up the filestore of old versions of files that are otherwise not cleaned up.
…urce Feat/handle error deleting old resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.