Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support running DP in circuit training #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhuhanqing
Copy link
Contributor

@zhuhanqing zhuhanqing commented Oct 25, 2022

Modify DREAMPlace such that it can run inside circuit training.
Add a flag use_dp_for_circuit_training to isolate changes with the main logic flow.

Copy link
Owner

@limbo018 limbo018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay. I have attached review comments. Your code has been merged into a new branch called circuit_training so that it does not affect the master branch. Please try to take a look at the review comments and send a new pull request.

dreamplace/Params.py Outdated Show resolved Hide resolved
dreamplace/PlaceDB.py Outdated Show resolved Hide resolved
dreamplace/params.json Outdated Show resolved Hide resolved
@zhuhanqing
Copy link
Contributor Author

Thanks for your comments! I have sent a new pull request with all comments being addressed.

@limbo018
Copy link
Owner

Thanks for your comments! I have sent a new pull request with all comments being addressed.

Thank you! The other PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants