Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flags and methods #152

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Rename flags and methods #152

merged 3 commits into from
Nov 7, 2023

Conversation

scott-huberty
Copy link
Member

@scott-huberty scott-huberty commented Nov 7, 2023

Closes #121
Closes #122

To be in line with our paper:

Current to New
flag_ch_sd_ch ➡️ flag_noisy_channels & flags["ch"]["noisy"]
flag_ch_low_r ➡️ flag_uncorrelated_channels & flags["ch"]["uncorrelated"]
flag_ch_bridge ➡️ flag_bridged_channesl & flags["ch"]["bridged"]
flag_ch_rank ➡️ flag_rank_channel & flags["ch"]["rank"]
flag_ch_sd_epoch ➡️ flag_noisy_epochs
flag_low_r_epochs ➡️ flag_uncorrelated_epochs
flag_ic_sd_1 ➡️ flag_noisy_ic_epochs

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #152 (f3d3439) into main (6197698) will decrease coverage by 0.14%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   78.70%   78.56%   -0.14%     
==========================================
  Files          21       21              
  Lines        1141     1143       +2     
==========================================
  Hits          898      898              
- Misses        243      245       +2     
Files Coverage Δ
pylossless/config/rejection.py 85.36% <100.00%> (ø)
pylossless/pipeline.py 74.20% <100.00%> (+0.06%) ⬆️
pylossless/flagging.py 63.88% <0.00%> (-0.90%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@scott-huberty scott-huberty merged commit 6b1db59 into lina-usc:main Nov 7, 2023
4 of 5 checks passed
@scott-huberty scott-huberty deleted the flag_renaming branch November 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on API Proposed API Changes:
1 participant