FIX: Don't import optional deps at the top-level #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #168 to land, then CI's should be happy.. |
This removes the WIP test for a simpler approach, first step of the CI after installing the hard deps is to import pylossless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138 imported
openneuroat the top of thedatasetsmodule, butopenneuro-pyis not a hard dependency of pylossless.This PR creates a soft import function that gets called only if/when a user calls the function in
pylossless.datasetsthat needsopenneuro-py, and raises an informative error if they don't have it installed.This will likely become handy if we need to do similar soft imports in the future.