Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line::from for (Point, Point), (Point, Vec2) #376

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Line::from for (Point, Point), (Point, Vec2) #376

merged 1 commit into from
Sep 11, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

Philipp-M
Philipp-M approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waywardmonkeys waywardmonkeys mentioned this pull request Sep 9, 2024
Merged
DJMcNab
DJMcNab reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using destructuring here

src/line.rs Outdated Show resolved Hide resolved
src/line.rs Outdated Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct once the push is actually done - if this is definitely an API we want, then I'd be happy to land this.

@waywardmonkeys
Copy link
Contributor Author

Will merge today if there's no objections registered.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit e34097b Sep 11, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the line-from branch September 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@Philipp-M Philipp-M Philipp-M approved these changes

@dfrg dfrg Awaiting requested review from dfrg

@richard-uk1 richard-uk1 Awaiting requested review from richard-uk1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @Philipp-M @DJMcNab