Use valid schema for Fixed field when deserializing data #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Dec 6, 2024
...de-tests-common/src/test/java/com/linkedin/avro/fastserde/FastDeserializerGeneratorTest.java
Show resolved
Hide resolved
...erde/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/FastDeserializerGenerator.java
Outdated
Show resolved
Hide resolved
nisargthakkar
force-pushed
the
schemaForFixedField
branch
from
60afc7f to
0a88955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reader and writer schemas are different for fields of type
Fixed, the deserialized objects are created withnullschema. This commit fixes that handling and adds a test case for itWithout the fix, the generated class has this:
With the fix, the generated class has this: