-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Adding Tracing(otel) to csi driver #309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 76.57% 73.15% -3.42%
==========================================
Files 22 23 +1
Lines 2403 2585 +182
==========================================
+ Hits 1840 1891 +51
- Misses 458 570 +112
- Partials 105 124 +19 ☔ View full report in Codecov by Sentry. |
… being the first connection
…ackage name to observeability package name
- reverted faulty span implementation in controllerserver_helper.go
- changed jaeger-service to a load-balancer - updated observability.md docs
- added notes on how to use functions in tracker.go - added images
docs/observability.md
Outdated
``` | ||
|
||
### 2. Delete the Existing Release of the CSI Driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Include if they have it installed. Some people might not
- added and to documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! LGTM
General:
This PR adds tracing to the csi driver controller and nodeserver.
Pull Request Guidelines: