Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement GET_VOLUME #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: implement GET_VOLUME #328

wants to merge 1 commit into from

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Nov 26, 2024

Report more information in volumeCondition for GET and LIST.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners November 26, 2024 09:20
@guilhem guilhem mentioned this pull request Nov 26, 2024
10 tasks
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.12%. Comparing base (17b7d1b) to head (ff7c61d).

Files with missing lines Patch % Lines
internal/driver/controllerserver.go 95.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   74.79%   75.12%   +0.33%     
==========================================
  Files          22       22              
  Lines        2396     2440      +44     
==========================================
+ Hits         1792     1833      +41     
- Misses        499      501       +2     
- Partials      105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Report more information in volumeCondition for GET and LIST.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants