update default CCM node selector and tolerations from master to control-plane #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
patch-1
branch
from
d6a72a4 to
d64ed9f
Compare
|
The change looks good to me. |
AshleyDumaine
changed the title
AshleyDumaine
changed the title
avestuk
approved these changes
Feb 16, 2024
eljohnson92
approved these changes
Feb 16, 2024
tchinmai7
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector for the CCM should be updated to account for the deprecation and removal of the
masternode-role. Currently, this doesn't work out-of-the-box on k8s 1.29 which uses onlynode-role.kubernetes.io/control-planefor control plane nodes.