Support for acls with >255 IPs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avestuk
reviewed
Feb 16, 2024
| Description: fmt.Sprintf("Rule %d, Created by linode-ccm: %s, for %s", i, label, svcName), | ||
| Protocol: linodego.TCP, // Nodebalancers support only TCP. | ||
| Ports: ports, | ||
| Addresses: linodego.NetworkAddresses{IPv4: &v4chunk}, |
There was a problem hiding this comment.
Upgrade to 1.22 while you are here? :D
There was a problem hiding this comment.
I thought the 1.22 bump went in already - looks like @okokes-akamai is on it in #173
avestuk
reviewed
Feb 16, 2024
There was a problem hiding this comment.
A firewall can have 25 rules in totall, would it make sense to handle that error checking here as well?
There was a problem hiding this comment.
should be sorted now
avestuk
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Adds support for firewall ACL with >255IPs, building intelligence into the ccm to break it up into chunks of ips.
Implemented an ip-split mechanism. will be adding a e2e test for the firewall feature as a whole shortly.
Pull Request Guidelines: