Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] : add unittests for node_controller #284

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Dec 23, 2024

This PR adds unittests for node_controller.go file

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the testing for updates to the testing suite in the changelog. label Dec 23, 2024
@rahulait rahulait force-pushed the add-node-controller-unittests branch from 7ef629a to 0f96702 Compare December 23, 2024 17:22
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.48%. Comparing base (b1b9af7) to head (0d2db68).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   57.92%   62.48%   +4.55%     
==========================================
  Files          12       12              
  Lines        2415     2415              
==========================================
+ Hits         1399     1509     +110     
+ Misses        864      755     -109     
+ Partials      152      151       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait force-pushed the add-node-controller-unittests branch from 0f96702 to dc54fe4 Compare December 23, 2024 17:50
@rahulait rahulait force-pushed the add-node-controller-unittests branch from 8089e24 to 0d2db68 Compare December 23, 2024 18:26
@rahulait rahulait requested a review from komer3 December 23, 2024 19:21
@rahulait rahulait merged commit 1e46ca0 into main Dec 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants