Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(commons): upgrade logging api #228

Merged
merged 8 commits into from
Mar 18, 2024
Merged

chore(commons): upgrade logging api #228

merged 8 commits into from
Mar 18, 2024

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Mar 18, 2024

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink(!) to copy git link (or open in browser).
  • Use GitLink(!) blame to copy the /blame link (or open in browser).
  • Use GitLink(!) default_branch to open the /main//master link in browser (or open in browser).
  • Use GitLink(!) current_branch to open the current branch link in browser (or open in browser).
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 77.05%. Comparing base (a5e0d3e) to head (390bddb).

Files Patch % Lines
lua/gitlinker.lua 57.14% 9 Missing ⚠️
lua/gitlinker/git.lua 80.00% 3 Missing ⚠️
lua/gitlinker/linker.lua 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   75.99%   77.05%   +1.06%     
==========================================
  Files           9        9              
  Lines         804      815      +11     
==========================================
+ Hits          611      628      +17     
+ Misses        193      187       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit f580992 into master Mar 18, 2024
9 checks passed
@linrongbin16 linrongbin16 deleted the chore-logging branch March 18, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant