Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMI/GSI pair suggestion #1529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mazorasaf
Copy link

@mazorasaf mazorasaf commented Dec 8, 2024

This PR addresses the issue related to the SMI/GSI separation in XDR-supported HCAs by introducing new methods and structures to the libibumad and libibmad libraries.

Changes in libibumad:

  • Added two new methods:
    • umad_get_smi_gsi_pairs
    • umad_get_smi_gsi_pairs_by_name
  • Introduced a new structure to represent SMI/GSI pairs:
    • umad_ca_pair

Changes in libibmad:

  • Added two new methods:
    • mad_rpc_open_port2
    • mad_rpc_close_port2
  • mad_rpc_open_port2 returns a pointer to a new structure ibmad_ports_pair, which holds the SMI/GSI port items, including the associated CA name and ibmad_port pointer.

Demonstration in smpquery:

The new API is demonstrated in smpquery, showing how to retrieve SMI/GSI details and pass the appropriate ibmad_port and CA name to the relevant methods based on the type of call (SMI or GSI).

For example:

  • GMP calls (e.g., resolve_portid_str) use the GSI port and GSI name.
  • SMP calls (e.g., smp_query_via) use the SMI port.

This enhancement ensures better handling of SMI/GSI separation when using the updated API.

@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 6 times, most recently from 29a5532 to 9bc7ec4 Compare December 12, 2024 12:55
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 2 times, most recently from 1a64530 to 262c589 Compare December 19, 2024 13:58
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch from 262c589 to 20f1af4 Compare December 25, 2024 10:10
supported HCAs by introducing new methods and structures to the libibumad and libibmad libraries.

### Changes in libibumad:
 - Added two new methods:
	  - umad_get_smi_gsi_pairs
	  - umad_get_smi_gsi_pairs_by_name
- Introduced a new structure to represent SMI/GSI pairs:
	 - umad_ca_pair

### Changes in libibmad:
- Added two new methods:
	- mad_rpc_open_port2
	- mad_rpc_close_port2
- mad_rpc_open_port2 returns a pointer to a new structure ibmad_ports_pair, which holds the SMI/GSI port items, including the associated CA name and ibmad_port pointer.

### Demonstration in smpquery:
The new API is demonstrated in smpquery, showing how to retrieve SMI/GSI details and pass the appropriate ibmad_port and CA name to the relevant methods based on the type of call (SMI or GSI).

For example:

- GMP calls (e.g., resolve_portid_str) use the GSI port and GSI name.
- SMP calls (e.g., smp_query_via) use the SMI port.

This enhancement ensures better handling of SMI/GSI separation when using the updated API.

Signed-off-by: Asaf Mazor <[email protected]>
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch from 20f1af4 to a1b60e3 Compare December 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant