Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue related to the SMI/GSI separation in XDR-supported HCAs by introducing new methods and structures to the
libibumad
andlibibmad
libraries.Changes in
libibumad
:umad_get_smi_gsi_pairs
umad_get_smi_gsi_pairs_by_name
umad_ca_pair
Changes in
libibmad
:mad_rpc_open_port2
mad_rpc_close_port2
mad_rpc_open_port2
returns a pointer to a new structureibmad_ports_pair
, which holds the SMI/GSI port items, including the associated CA name andibmad_port
pointer.Demonstration in
smpquery
:The new API is demonstrated in
smpquery
, showing how to retrieve SMI/GSI details and pass the appropriateibmad_port
and CA name to the relevant methods based on the type of call (SMI or GSI).For example:
resolve_portid_str
) use the GSI port and GSI name.smp_query_via
) use the SMI port.This enhancement ensures better handling of SMI/GSI separation when using the updated API.