Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/flashprog: bump to latest commit, including support for meteor lake #1865

Merged

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Nov 28, 2024

To be tested under #1846 and reported functional so I can press merge button. Will test on nv41 and x230 on my side, seeing changes, we should not have regressions

CC @i-c-o-n @mkopec


Test regression (once Ci builds everything supported today) on my side for

  • x230 (sandy/ivy representative)
  • nv41 (alder lake represenative)

Other:

…r lake

We use SourceArcade/flashprog@eb2c041 (2024-11-21 1.3+ bugfixes)
Where meteor lake is SourceArcade/flashprog@5e0d9b0 is from 1.3 (3 weeks ago)

Signed-off-by: Thierry Laurion <[email protected]>
@mkopec
Copy link
Contributor

mkopec commented Nov 28, 2024

All good on V540TU. Was able to perform OEM re-ownership and generate new TOTP secrets, reboot, and verify that the config persisted.

@tlaurion
Copy link
Collaborator Author

All good on V540TU. Was able to perform OEM re-ownership and generate new TOTP secrets, reboot, and verify that the config persisted.

Awesome news.
So will wait that CI finishes building for 3de473c and test for regression and merge once that is done!

Can you point to proper coreboot commit under #1835 ? Seems like I will be a busy bee for the next days. Ideal there is that the issues there are tackled and can do basic tests and tweaks and do only Heads related stuff, ie #1814

@mkopec can you test #1814 and poke @miczyg1 internally if that doesnt work for meteor lake under coreboot review ticket from there please?

@tlaurion tlaurion changed the title modules/flashprog: bump to latest commit, including support for meteo lake modules/flashprog: bump to latest commit, including support for meteor lake Nov 28, 2024
@tlaurion tlaurion marked this pull request as ready for review November 28, 2024 20:31
@tlaurion
Copy link
Collaborator Author

x230/nvx_adl (nv41) and v540tu: still works with flashprog without regression, merging!

@tlaurion
Copy link
Collaborator Author

@JonathonHall-Purism please report regresion if any, but no regression found and changes are pretty specific from changelog, should not break anything but if it does for librems, please open issue asap!

@tlaurion tlaurion merged commit 87732b7 into linuxboot:master Nov 28, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants