Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the issue of waiting for restart after exiting #200

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

pengfeixx
Copy link
Contributor

Fixed the issue of waiting for restart after exiting

Bug: https://pms.uniontech.com/bug-view-289921.html
Log: Fixed the issue of waiting for restart after exiting

Fixed the issue of waiting for restart after exiting

Bug: https://pms.uniontech.com/bug-view-289921.html
Log: Fixed the issue of waiting for restart after exiting
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • main.qml中新增的IV.GControl.forceExit();调用可能会引起应用程序的非正常退出,需要确认这是否是预期的行为。
  • GlobalControl::forceExit方法中调用了QApplication::exit(0)_Exit(0),这两个函数都会导致应用程序立即退出,可能会丢失未保存的数据,需要确保这是在用户明确要求退出时才调用。

是否建议立即修改:

  • 是,需要确认forceExit方法的调用时机和逻辑,确保不会导致数据丢失或非预期行为。如果这个方法是用来处理异常情况,应该添加相应的错误处理和用户提示。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 2, 2024

This pr cannot be merged! (status: unstable)

@pengfeixx pengfeixx merged commit 9633aa4 into linuxdeepin:master Dec 2, 2024
18 of 20 checks passed
@pengfeixx pengfeixx deleted the exit branch December 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants