Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ocr position offset on HiDPI displays #206

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

rb-union
Copy link
Contributor

  • Add devicePixelRatio support to fix text box positioning on HiDPI screens
  • Remove Image.Tile fillMode for better DPI compatibility
  • Scale image dimensions based on device pixel ratio

Log: Fix ocr position offset on HiDPI displays.
Bug: https://pms.uniontech.com/bug-view-275403.html

- Add devicePixelRatio support to fix text box positioning on HiDPI screens
- Remove Image.Tile fillMode for better DPI compatibility
- Scale image dimensions based on device pixel ratio

Log: Fix ocr position offset on HiDPI displays.
Bug: https://pms.uniontech.com/bug-view-275403.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • LiveBlock.qml文件中,注释应该更详细地解释为什么需要使用默认的fillMode
  • livetextanalyzer.cpp文件中,setImage函数中对于设备像素比的判断和图像缩放逻辑可能需要更详细的注释,以便理解其目的。
  • livetextanalyzer.cpp文件中,analyze函数中的while循环可能会导致阻塞,应该考虑使用更高效的等待机制。
  • livetextanalyzer.cpp文件中,requestImage函数中对于图像的缩放逻辑可能需要更详细的注释,以便理解其目的。
  • livetextanalyzer.h文件中,pixelRatio成员变量的注释应该更详细地解释其用途。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link

myk1343 commented Dec 25, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@rb-union rb-union merged commit 428bb99 into linuxdeepin:master Dec 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants