Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the issue that the camera failed to be turned on #548

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pengfeixx
Copy link
Contributor

Fixed the issue that the camera failed to be turned on

Log: Fixed the issue that the camera failed to be turned on

Fixed the issue that the camera failed to be turned on

Log: Fixed the issue that the camera failed to be turned on
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 代码重复

    • dbus_adpator.cppplatform_dbus_adpator.cpp 文件中的 openFilesopenFile 函数逻辑相同,只是类名不同。建议将这两个函数提取到一个公共基类中,以减少代码重复。
  2. 时间间隔判断逻辑

    • openFilesopenFile 函数中,移除了对时间间隔的判断逻辑。如果这个逻辑是必要的,应该保留,并确保其正确性。如果不需要,应该移除相关的注释和代码,以保持代码的清晰。
  3. 成员变量 m_oldTime 的使用

    • m_oldTime 成员变量在 openFilesopenFile 函数中被移除,但在构造函数中仍然被初始化。如果这个变量不再需要,应该从类定义中移除。如果需要,应该确保在使用前正确初始化。
  4. 代码注释

    • 移除了对时间间隔判断逻辑的注释,如果这个逻辑是必要的,应该保留注释以解释其目的。
  5. 代码风格

    • 在移除代码时,应该保持代码格式的一致性,例如缩进和空格的使用。
  6. 单元测试

    • 如果移除时间间隔判断逻辑会影响单元测试,应该更新相应的测试用例以反映这一变化。

综上所述,建议进行以下修改:

  • 如果时间间隔判断逻辑是必要的,应该将其恢复,并确保其正确性。
  • 如果不需要这个逻辑,应该移除相关的代码和注释。
  • openFilesopenFile 函数提取到一个公共基类中,以减少代码重复。
  • 确保所有移除的代码都有相应的注释,以解释为什么移除。
  • 保持代码格式的一致性。

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit a86b68b into linuxdeepin:develop/snipe Dec 19, 2024
15 checks passed
@pengfeixx pengfeixx deleted the bufix branch December 19, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants