Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Support Python 3.12 #256

Closed
wants to merge 3 commits into from
Closed

build: Support Python 3.12 #256

wants to merge 3 commits into from

Conversation

l0b0
Copy link
Collaborator

@l0b0 l0b0 commented Oct 9, 2023 •
edited
Loading

Blocked by sat-search (fix) and sat-stac (fix). Neither of those are maintained; they have not merged any PRs since 2022. Options include at least:

  • Fork the repos, merge the fixes, and use the new repos instead.
  • Migrate to different packages.
  • Just don't support Python 3.12 indefinitely.
  • Decommission the Jupyter notebook. @mfwightman, is anyone still using this?

@l0b0 l0b0 requested a review from mfwightman October 9, 2023 02:36
@l0b0 l0b0 added the automerge label Oct 9, 2023
@l0b0 l0b0 removed the request for review from mfwightman October 9, 2023 20:09
@l0b0 l0b0 marked this pull request as draft October 9, 2023 20:09
@l0b0 l0b0 removed the automerge label Oct 9, 2023
@l0b0 l0b0 force-pushed the build/support-python-3-12 branch from 0359b23 to b60568d Compare October 19, 2023 02:03
@l0b0 l0b0 marked this pull request as ready for review October 19, 2023 02:16
@l0b0 l0b0 requested a review from mfwightman October 19, 2023 02:16
@l0b0 l0b0 enabled auto-merge (rebase) October 19, 2023 02:17
mfwightman
mfwightman previously approved these changes Oct 19, 2023
View reviewed changes
@l0b0 l0b0 disabled auto-merge October 19, 2023 02:43
@l0b0 l0b0 marked this pull request as draft October 19, 2023 02:43
@l0b0 l0b0 force-pushed the build/support-python-3-12 branch from ce0fb15 to 2feeb0a Compare December 12, 2023 01:02
@l0b0 l0b0 force-pushed the build/support-python-3-12 branch from 350c76d to f50b976 Compare May 8, 2024 01:21
@l0b0 l0b0 force-pushed the build/support-python-3-12 branch 5 times, most recently from 6a46002 to 566aba3 Compare May 15, 2024 22:09
l0b0 added 2 commits May 23, 2024 13:40
@l0b0
build: Bump Python packages
08bccd1 
Challenges:

- Had to hold back GDAL from 3.9 because it's not yet in nixpkgs
   <NixOS/nixpkgs#311310>.
- Had to hold back numexpr from 2.10 because it's not yet in nixpkgs
   <NixOS/nixpkgs#310837>.
- Had to hold back matplotlib from 3.9 because it needs a poetry2nix
   override <nix-community/poetry2nix#1659>.
- Had to force sat-search version 0.3.0 to avoid Poetry downgrading it to
   0.1.0.
- Had to add Cython 0 to the color-operations build inputs
   <nix-community/poetry2nix#1658>.

Script:

```bash
cd flooding/sentinel2_water_extraction
poetry add --lock gdal="<3.9" matplotlib="<3.9" numexpr="<2.10" sat-search=">=0.3.0"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
cd ../sentinel1_water_extraction/
poetry add --lock gdal="<3.9"
poetry update --lock
git checkout pyproject.toml
poetry lock --no-update
```
@l0b0
build: Support Python 3.12
5087a34
@l0b0 l0b0 force-pushed the build/support-python-3-12 branch from 566aba3 to 5087a34 Compare May 23, 2024 02:01
@l0b0
Copy link
Collaborator Author

l0b0 commented Nov 28, 2024

Archiving repo; closing so the PRs don't hang around forever.

@l0b0 l0b0 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfwightman mfwightman mfwightman left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0b0 @mfwightman