Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A #spoiler suggestion #448

Closed
imscary opened this issue Oct 15, 2019 · 3 comments · Fixed by #534
Closed

A #spoiler suggestion #448

imscary opened this issue Oct 15, 2019 · 3 comments · Fixed by #534
Labels
contributions welcome Feel free to assign this issue to yourself and work on it

Comments

@imscary
Copy link
Contributor

imscary commented Oct 15, 2019

#spoiler

will play the dweet only when clicked on canvas for every dweet tagged with #spoiler
the autoplay will be disabled & recieveMessage should work different. Is it too hard to implement this? Similar to the discordapp's spoiler system. This is useful for #394 too

A image should be shown before clicking the canvas. Something like:
image

I think it is useful for heavy dweets, audio dweets, nsfw jokes dweets & every other kind of dweet that shouldn't be played automatically. What do you guys think?

@lionleaf lionleaf added the contributions welcome Feel free to assign this issue to yourself and work on it label Nov 16, 2019
@lionleaf
Copy link
Owner

As mentioned in #394 I definitely think this would be very useful :) Is spoiler the right term for it? We generally don't deal with actual spoilers, but the spoiler tag seems to be used for this purpose elsewhere. I can't think of any better term at the moment though.

Tagging this with "contributions welcome". If you feel like you want to implement this, please assign yourself and feel free to reach out to me for help / feedback.

@rep-movsd
Copy link
Collaborator

Since the first NSFW tweet I know of has appeared on dwitter and some of us are really in work/home situations where we need some NSFW filtration, I am going to work on this feature.
The first step will be to modify the dweet.html to be "click to reveal" if a param called "spoiler" is passed.

The exact mechanism to pass that in from the frontend can be decided - my initial idea is to check for certain hashtags - chiefly NSFW anywhere in the comments.

Or "#nsfw" in the title, and admins can step in and add the tag if the author forgets to.

@KilledByAPixel
Copy link
Collaborator

Thank you for doing this!

It is not my goal to offend just trying to bring more attention to dwitter and make some people laugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Feel free to assign this issue to yourself and work on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants