Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start dweet paused and hidden if URL parameter "spoiler" is specified #534

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Start dweet paused and hidden if URL parameter "spoiler" is specified #534

merged 1 commit into from
Dec 5, 2021

Conversation

rep-movsd
Copy link
Collaborator

Fixes #448 for the backend

Adding spoiler=1 to the dweet url will keep it paused and hidden until user clicks

@rep-movsd rep-movsd mentioned this pull request Dec 2, 2021
Merged
lionleaf
lionleaf approved these changes Dec 5, 2021
View reviewed changes
Copy link
Owner

@lionleaf lionleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

You forgot to set the overlay to hidden for non-spoiler dweets, but happy to merge and just fix that before deploying :)

@lionleaf lionleaf merged commit 34d9387 into lionleaf:master Dec 5, 2021
@lionleaf lionleaf mentioned this pull request Dec 5, 2021
Merged
2 tasks
@rep-movsd rep-movsd deleted the spoiler-dweets branch December 6, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionleaf lionleaf lionleaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A #spoiler suggestion
2 participants
@rep-movsd @lionleaf